Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ONYX-11120 - Audience variable integration into main jwt flow #2345

Merged
merged 3 commits into from
Jul 28, 2021

Conversation

sashaCher
Copy link
Contributor

What does this PR do?

Integrates audience variable into main authn-jwt flow.
Automation sanity tests.

What ticket does this PR close?

Resolves #[relevant GitHub issues, eg 76]

Checklists

Change log

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, or
  • This PR does not require updating any documentation

API Changes

  • The OpenAPI spec has been updated to meet new API changes (or an issue has been opened), or
  • The changes in this PR do not affect the Conjur API

@sashaCher sashaCher requested a review from a team July 28, 2021 10:54
tzheleznyak
tzheleznyak previously approved these changes Jul 28, 2021
@sashaCher sashaCher marked this pull request as ready for review July 28, 2021 13:13
@sashaCher sashaCher requested a review from a team as a code owner July 28, 2021 13:13
tzheleznyak
tzheleznyak previously approved these changes Jul 28, 2021
Copy link
Contributor

@tzheleznyak tzheleznyak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@tzheleznyak tzheleznyak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codeclimate
Copy link

codeclimate bot commented Jul 28, 2021

Code Climate has analyzed commit d470fd8 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 90.9% (0.0% change).

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants