Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update website Dockerfiles for CVE-2022-0778 #1475

Merged
merged 3 commits into from
Sep 28, 2022
Merged

Conversation

john-odonnell
Copy link
Contributor

@john-odonnell john-odonnell commented Sep 22, 2022

Desired Outcome

Upgrade website Docker images to address CVE-2022-0778.

Implemented Changes

Upgrade website Docker images to their Ruby 3.0 counterparts.

Connected Issue/Story

CyberArk internal issue link: CONJSE-1317

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: insert issue ID
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

docs/Gemfile Outdated Show resolved Hide resolved
docs/Gemfile Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
## [1.7.15] - 2022-09-22

### Security
- Upgrade website Dockerfiles to Ruby 3 to resolve CVE-2022-0778.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lists should be surrounded by blank lines

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpothier: Fixed all CC issues but this one, which breaks our typical changelog format. Should be ready for another review.

@john-odonnell john-odonnell marked this pull request as ready for review September 22, 2022 19:22
@john-odonnell john-odonnell requested a review from a team as a code owner September 22, 2022 19:22
rpothier
rpothier previously approved these changes Sep 26, 2022
Copy link
Contributor

@rpothier rpothier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just have to make codeclimate happy.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@codeclimate
Copy link

codeclimate bot commented Sep 27, 2022

Code Climate has analyzed commit 0f85405 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Style 1

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 40.1% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@szh szh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@john-odonnell john-odonnell merged commit 158370d into main Sep 28, 2022
@john-odonnell john-odonnell deleted the website-dockerfiles branch September 28, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants