Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update script to print logs on error #1499

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Update script to print logs on error #1499

merged 1 commit into from
Jun 13, 2023

Conversation

rpothier
Copy link
Contributor

@rpothier rpothier commented Jun 9, 2023

Desired Outcome

On an error with the CRD tests, the logs should be printed.

Implemented Changes

Update the CRD test script to print the logs.

Connected Issue/Story

Resolves #[relevant GitHub issue(s), e.g. 76]

CyberArk internal issue ID: [insert issue ID]

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@rpothier rpothier self-assigned this Jun 9, 2023
@rpothier rpothier marked this pull request as ready for review June 12, 2023 13:57
@rpothier rpothier requested a review from a team as a code owner June 12, 2023 13:57
## [1.7.18] - 2023-06-12

### Changed
- Update CRD test script.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lists should be surrounded by blank lines

@codeclimate
Copy link

codeclimate bot commented Jun 12, 2023

Code Climate has analyzed commit e96bfd3 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Style 1

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 70.7% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@gl-johnson gl-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rpothier rpothier merged commit 93d512f into main Jun 13, 2023
3 checks passed
@rpothier rpothier deleted the crd-issues branch June 13, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants