Skip to content
This repository has been archived by the owner on Dec 18, 2018. It is now read-only.

Use jQuery Layout UI to create a resizable/closable menu at west #105

Closed
wants to merge 6 commits into from

Conversation

fabienrohrer
Copy link
Member

Ditto

@fabienrohrer
Copy link
Member Author

The first results are very encouraging: it simplifies the layout code drastically and is very smooth to use.

Example:

  • default menu width:

capture d ecran 2016-06-28 a 17 56 36

  • big menu width:

capture d ecran 2016-06-28 a 17 56 47

  • closed menu:

capture d ecran 2016-06-28 a 17 56 51

@fabienrohrer
Copy link
Member Author

@omichel Could I ask you to try apply this on the Cyberbotics website?

In theory, this should be straight forward:

@fabienrohrer
Copy link
Member Author

👍

@stefaniapedrazzi
Copy link
Member

How do you close the menu? simply dragging on the left?
I cannot close it in the dock widget.. but the resizing works fine.

@fabienrohrer
Copy link
Member Author

By double-clicking on the drag handle..
I tried quickly to do the same way we do in Webots, but didn't find a solution yet. I will investigate more right now.

@stefaniapedrazzi
Copy link
Member

Ok, thank you. With double click it works fine.
But the area where you have to double click is quite small.

Some subsection title seems to be cut, in this case we should re-add the horizontal scrollbar:
dock_widget

@stefaniapedrazzi
Copy link
Member

Maybe we could also further reduce the minimum size.
Ideally not having any minimum size would probably be better.

@fabienrohrer
Copy link
Member Author

Your propositions are good to me.

If I reduce the minimum size to 0, it acts like a second and more intuitive way to close the menu.
I have issues to set the horizontal scroll bar under some minimum width, but this is certainly possible, I'm investigating this.

@stefaniapedrazzi
Copy link
Member

By the way a single click on the handle (highlighted in yellow) works as well to hide the left menu.

@fabienrohrer
Copy link
Member Author

thank you for the tip

@omichel
Copy link
Member

omichel commented Jun 29, 2016

I just tested it on cyberbotics's web site and it doesn't work (nothing is actually displayed).
You can test also by yourself as I put the interesting files (webots-doc.css doc.php and viewer.js) on the FTP server of Cyberbotics in repository/www/wwi/8.5.

@fabienrohrer
Copy link
Member Author

Ok, thank you. I didn't know I had access to doc.php. So I can go on with this if you would like.

@omichel
Copy link
Member

omichel commented Jun 29, 2016

Yes, please.

@fabienrohrer
Copy link
Member Author

@stefaniapedrazzi I implemented your propositions and it seems to be simpler to use now.

@fabienrohrer
Copy link
Member Author

On the Cyberbotics website, there are height issues similar to the ones we get with iframes.

@omichel
Copy link
Member

omichel commented Jun 29, 2016

The doc on the web site is currently broken: https://www.cyberbotics.com/doc/guide/index
Nothing is displayed any more...

@fabienrohrer
Copy link
Member Author

Yes, because I'm currently working on this. I will restore this, and try to work locally rather.

@omichel
Copy link
Member

omichel commented Jun 29, 2016

Ok, thank you.

@fabienrohrer
Copy link
Member Author

The previous state is restored.

@fabienrohrer
Copy link
Member Author

I have a working example here:
https://github.com/omichel/webots-doc/blob/enhancement-resizable-menu/test.html

Remains to apply it ;-)

@fabienrohrer
Copy link
Member Author

The last results I get with this implementation are not satisfying. Probably due to the dynamic load, the height of the container is difficult to compute, and I ask myself if the overall is the good approach.

@fabienrohrer
Copy link
Member Author

Solution in #116 is preferable to this solution.

@fabienrohrer fabienrohrer deleted the enhancement-resizable-menu branch July 6, 2016 10:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

None yet

3 participants