Skip to content
This repository has been archived by the owner on Dec 18, 2018. It is now read-only.

Split CSS #90

Merged
merged 12 commits into from
Jun 28, 2016
Merged

Split CSS #90

merged 12 commits into from
Jun 28, 2016

Conversation

fabienrohrer
Copy link
Member

Attempt to fix #64

@fabienrohrer
Copy link
Member Author

👍

font-style: normal;
font-weight: 100;
src:local("Raleway Thin"),local("Raleway-Thin"),url("Raleway-Thin.woff") format("woff")
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we simply remove this file?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commited this file by mistake.

@fabienrohrer
Copy link
Member Author

👍

@omichel
Copy link
Member

omichel commented Jun 28, 2016

👍 (I am not convinced by the extra div encapsulating the doc, because it is not needed in our case and I consider it as an extra overhead ; if some user need it for layout purposes, it is very easy to add it. But OK, it's a detail).

@fabienrohrer fabienrohrer merged commit add2a54 into master Jun 28, 2016
@fabienrohrer fabienrohrer deleted the enhancement-css-split branch June 28, 2016 07:46
@fabienrohrer
Copy link
Member Author

@omichel Could I ask you to try apply this PR on the Cyberbotics website?

@omichel
Copy link
Member

omichel commented Jun 29, 2016

Done.

@fabienrohrer
Copy link
Member Author

perfect, thank you.

@omichel
Copy link
Member

omichel commented Jun 29, 2016

Well, it doesn't work as expect... I am investigating why...

@fabienrohrer
Copy link
Member Author

What is the issue?

@omichel
Copy link
Member

omichel commented Jun 29, 2016

The CSS was wrong. I fixed just it on the web site.
Instead of #webots-doc (CSS id selector), you should have used .webots-doc (CSS class selector).
I believe this PR should be fixed accordingly.

@fabienrohrer
Copy link
Member Author

I use .webots-doc: https://github.com/omichel/webots-doc/blob/master/css/webots-doc.css

Is your branch up-to-date?

@fabienrohrer
Copy link
Member Author

(I used #webots-doc in a previous/obsolete commit.)

@omichel
Copy link
Member

omichel commented Jun 29, 2016

Ok, that was the problem. I uploaded the correct version now. Thank you.

@omichel
Copy link
Member

omichel commented Jun 29, 2016

So, now the web site is using the latest version: https://www.cyberbotics.com/doc/guide
Can you check it?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

Use the class HTML attribute to better style the documentation
2 participants