Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update object icons #14

Merged
merged 25 commits into from Dec 6, 2018
Merged

Update object icons #14

merged 25 commits into from Dec 6, 2018

Conversation

fabienrohrer
Copy link
Member

@fabienrohrer fabienrohrer commented Dec 4, 2018

  • Restore icon_studio
  • Adapt it to PBR
  • Optimize the performance (before 5 hours; now 30 minutes)
  • Copy the resulted icon in the docs images.
  • Apply it on the object icons

@fabienrohrer fabienrohrer added this to the R2019a milestone Dec 4, 2018
@fabienrohrer fabienrohrer self-assigned this Dec 4, 2018
@fabienrohrer
Copy link
Member Author

test me

@cyberbotics-jenkins
Copy link

Build Passed 👌
You can safely merge 'update-object-icons' into 'master'.

@fabienrohrer
Copy link
Member Author

With this PR, I do no guarantee the exhaustivity of the icons generation, I only updated the icons existing in the objects.json file.
I think this is already a good step to be merged.

@fabienrohrer
Copy link
Member Author

test me

@cyberbotics-jenkins
Copy link

Build Passed 👌
You can safely merge 'update-object-icons' into 'master'.

@fabienrohrer
Copy link
Member Author

👍

@cyberbotics-jenkins
Copy link

Build Passed 👌
You can safely merge 'update-object-icons' into 'master'.

@DavidMansolino
Copy link
Member

👀

@DavidMansolino
Copy link
Member

With this PR, I do no guarantee the exhaustivity of the icons generation, I only updated the icons existing in the objects.json file.
I think this is already a good step to be merged.

I checked a few monthes ago the list was exhaustive.

@fabienrohrer
Copy link
Member Author

Great. I just fear we introduced new PROTOs meanwhile. I'm checking right now.

Copy link
Member

@DavidMansolino DavidMansolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have checked all the images (only big ones, I assume the icons are the same) and the script is working perfectly, almost all the images are way better than the previous one, just a few ones are problematic.

Wrong background removal:

docs/guide/images/objects/buildings/UBuilding/model.png
docs/guide/images/objects/drinks/WaterBottle/model.png
docs/guide/images/objects/garden/SwingCouch/model.png
docs/guide/images/objects/street_furniture/Atm/model.png
docs/guide/images/objects/traffic/CautionPanel/model.png
docs/guide/images/objects/traffic/CautionSign/model.png
docs/guide/images/objects/traffic/StopPanel/model.png
docs/guide/images/objects/utensils/Carafe/model.png   (very bad)
docs/guide/images/objects/utensils/Plate/model.png
docs/guide/images/objects/utensils/Wineglass/model.png (very bad)

Issue with crop:

docs/guide/images/objects/living_room_furniture/Carpet/model.png

@fabienrohrer
Copy link
Member Author

Thank you, I'm fixing this.

@fabienrohrer
Copy link
Member Author

Finally, I will try also to ensure the exhaustivity here. There are only few things to do.

@fabienrohrer
Copy link
Member Author

test me

@cyberbotics-jenkins
Copy link

Build Passed 👌
You can safely merge 'update-object-icons' into 'master'.

@fabienrohrer
Copy link
Member Author

👍

@fabienrohrer fabienrohrer merged commit a984370 into master Dec 6, 2018
@fabienrohrer fabienrohrer deleted the update-object-icons branch December 6, 2018 15:39
omichel pushed a commit that referenced this pull request Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants