New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update object icons #14
Conversation
fabienrohrer
commented
Dec 4, 2018
•
edited
edited
- Restore icon_studio
- Adapt it to PBR
- Optimize the performance (before 5 hours; now 30 minutes)
- Copy the resulted icon in the docs images.
- Apply it on the object icons
test me |
Build Passed 👌 |
With this PR, I do no guarantee the exhaustivity of the icons generation, I only updated the icons existing in the objects.json file. |
test me |
Build Passed 👌 |
👍 |
Build Passed 👌 |
👀 |
I checked a few monthes ago the list was exhaustive. |
Great. I just fear we introduced new PROTOs meanwhile. I'm checking right now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have checked all the images (only big ones, I assume the icons are the same) and the script is working perfectly, almost all the images are way better than the previous one, just a few ones are problematic.
Wrong background removal:
docs/guide/images/objects/buildings/UBuilding/model.png
docs/guide/images/objects/drinks/WaterBottle/model.png
docs/guide/images/objects/garden/SwingCouch/model.png
docs/guide/images/objects/street_furniture/Atm/model.png
docs/guide/images/objects/traffic/CautionPanel/model.png
docs/guide/images/objects/traffic/CautionSign/model.png
docs/guide/images/objects/traffic/StopPanel/model.png
docs/guide/images/objects/utensils/Carafe/model.png (very bad)
docs/guide/images/objects/utensils/Plate/model.png
docs/guide/images/objects/utensils/Wineglass/model.png (very bad)
Issue with crop:
docs/guide/images/objects/living_room_furniture/Carpet/model.png
Thank you, I'm fixing this. |
Finally, I will try also to ensure the exhaustivity here. There are only few things to do. |
test me |
Build Passed 👌 |
👍 |