Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Windows distribution #38

Merged
merged 10 commits into from
Dec 12, 2018
Merged

Fix Windows distribution #38

merged 10 commits into from
Dec 12, 2018

Conversation

omichel
Copy link
Member

@omichel omichel commented Dec 7, 2018 •
edited

Fixes #33, #34 and #36.
Unfortunately, I could not fix #35.

@omichel omichel added the bug Something isn't working label Dec 7, 2018
@omichel omichel added this to the R2019a milestone Dec 7, 2018
@omichel omichel self-assigned this Dec 7, 2018
@omichel
Copy link
Member Author

omichel commented Dec 11, 2018

test me

@cyberbotics-jenkins
Copy link

Build Passed 👌
You can safely merge 'fix-windows-distribution' into 'master'.

@omichel
Copy link
Member Author

omichel commented Dec 11, 2018

👍

@tpjnorton tpjnorton mentioned this pull request Dec 11, 2018
Merged
@DavidMansolino
Copy link
Member

👀

@DavidMansolino
Copy link
Member

I confirm the three issues are fixed, I will just do a final test in a clean VM.

tpjnorton
tpjnorton previously approved these changes Dec 12, 2018
View reviewed changes
@omichel
Copy link
Member Author

omichel commented Dec 12, 2018

👍

@omichel omichel merged commit c3cd648 into master Dec 12, 2018
@omichel omichel deleted the fix-windows-distribution branch December 12, 2018 08:14
This was referenced Dec 12, 2018
Closed
Closed
DavidMansolino
DavidMansolino reviewed Dec 12, 2018
View reviewed changes
Copy link
Member

@DavidMansolino DavidMansolino left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sorry but the platform plugin issue is still present, it is now even worse as I can reproduce it in all of my environments (clean VM + usual OS with development environment).
Edit: the version on the ftp doesn't contains the last commit.

@tpjnorton
Copy link
Contributor

Sorry, I should have mentioned that I fixed the release locally and olivier applied the commit after creating the test package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidMansolino DavidMansolino DavidMansolino left review comments

@tpjnorton tpjnorton tpjnorton approved these changes

Assignees

@omichel omichel

Labels
bug Something isn't working
Milestone
R2019a
4 participants
@omichel @cyberbotics-jenkins @DavidMansolino @tpjnorton