Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Python Node.disablePoseTracking #5591

Merged
merged 1 commit into from
Nov 28, 2022
Merged

Fix Python Node.disablePoseTracking #5591

merged 1 commit into from
Nov 28, 2022

Conversation

stefaniapedrazzi
Copy link
Member

The wrong C function is called in Node.disablePoseTracking.

@stefaniapedrazzi stefaniapedrazzi added the bug Something isn't working label Nov 28, 2022
@stefaniapedrazzi stefaniapedrazzi added this to the R2023a milestone Nov 28, 2022
@stefaniapedrazzi stefaniapedrazzi self-assigned this Nov 28, 2022
@stefaniapedrazzi
Copy link
Member Author

I also noticed that it is not consistent that the wb_supervisor_node_enable_pose_tracking support a NULL from_node argument, but the wb_supervisor_node_disable_pose_tracking doesn't support it.
I will open an issue for this.

@stefaniapedrazzi stefaniapedrazzi marked this pull request as ready for review November 28, 2022 16:49
@stefaniapedrazzi stefaniapedrazzi requested a review from a team as a code owner November 28, 2022 16:49
@ygoumaz ygoumaz self-requested a review November 28, 2022 16:51
ygoumaz
ygoumaz approved these changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@ygoumaz ygoumaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@stefaniapedrazzi stefaniapedrazzi merged commit 1c1d0fe into master Nov 28, 2022
@stefaniapedrazzi stefaniapedrazzi deleted the hotfix-python-disable-pose-tracking branch November 28, 2022 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ygoumaz ygoumaz ygoumaz approved these changes

Assignees

@stefaniapedrazzi stefaniapedrazzi

Labels
bug Something isn't working
Milestone
R2023a
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stefaniapedrazzi @ygoumaz