Skip to content

Commit

Permalink
Make jobs class naming more explicit (#149)
Browse files Browse the repository at this point in the history
Make reactant jobs class names more explicit
  • Loading branch information
antonkomarev committed Feb 8, 2020
1 parent f2ddfff commit f08741e
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions CHANGELOG.md
Expand Up @@ -4,8 +4,8 @@ All notable changes to `laravel-love` will be documented in this file.

## [Unreleased]

- ([#146]) Extracted logic from `Cog\Laravel\Love\Reactant\Listeners\IncrementAggregates` listener to `Cog\Laravel\Love\Reactant\Jobs\IncrementAggregatesJob`
- ([#146]) Extracted logic from `Cog\Laravel\Love\Reactant\Listeners\DecrementAggregates` listener to `Cog\Laravel\Love\Reactant\Jobs\DecrementAggregatesJob`
- ([#146]) Extracted logic from `Cog\Laravel\Love\Reactant\Listeners\IncrementAggregates` listener to `Cog\Laravel\Love\Reactant\Jobs\IncrementReactionAggregatesJob`
- ([#146]) Extracted logic from `Cog\Laravel\Love\Reactant\Listeners\DecrementAggregates` listener to `Cog\Laravel\Love\Reactant\Jobs\DecrementReactionAggregatesJob`
- ([#147]) Extracted event listeners registering from `Cog\Laravel\Love\LoveServiceProvider` to `Cog\Laravel\Love\LoveEventServiceProvider`

## [8.2.0] - 2020-01-30
Expand Down
Expand Up @@ -21,7 +21,7 @@
use Illuminate\Contracts\Queue\ShouldQueue;
use Illuminate\Foundation\Bus\Dispatchable;

final class DecrementAggregatesJob implements
final class DecrementReactionAggregatesJob implements
ShouldQueue
{
use Dispatchable;
Expand Down
Expand Up @@ -21,7 +21,7 @@
use Illuminate\Contracts\Queue\ShouldQueue;
use Illuminate\Foundation\Bus\Dispatchable;

final class IncrementAggregatesJob implements
final class IncrementReactionAggregatesJob implements
ShouldQueue
{
use Dispatchable;
Expand Down
4 changes: 2 additions & 2 deletions src/Reactant/Listeners/DecrementAggregates.php
Expand Up @@ -13,7 +13,7 @@

namespace Cog\Laravel\Love\Reactant\Listeners;

use Cog\Laravel\Love\Reactant\Jobs\DecrementAggregatesJob;
use Cog\Laravel\Love\Reactant\Jobs\DecrementReactionAggregatesJob;
use Cog\Laravel\Love\Reaction\Events\ReactionHasBeenRemoved;
use Illuminate\Contracts\Bus\Dispatcher;
use Illuminate\Contracts\Queue\ShouldQueue;
Expand Down Expand Up @@ -42,7 +42,7 @@ public function handle(ReactionHasBeenRemoved $event): void
$reactant = $reaction->getReactant();

$this->dispatcher->dispatch(
new DecrementAggregatesJob($reactant, $reaction)
new DecrementReactionAggregatesJob($reactant, $reaction)
);
}
}
4 changes: 2 additions & 2 deletions src/Reactant/Listeners/IncrementAggregates.php
Expand Up @@ -13,7 +13,7 @@

namespace Cog\Laravel\Love\Reactant\Listeners;

use Cog\Laravel\Love\Reactant\Jobs\IncrementAggregatesJob;
use Cog\Laravel\Love\Reactant\Jobs\IncrementReactionAggregatesJob;
use Cog\Laravel\Love\Reaction\Events\ReactionHasBeenAdded;
use Illuminate\Contracts\Bus\Dispatcher;
use Illuminate\Contracts\Queue\ShouldQueue;
Expand Down Expand Up @@ -42,7 +42,7 @@ public function handle(ReactionHasBeenAdded $event): void
$reactant = $reaction->getReactant();

$this->dispatcher->dispatch(
new IncrementAggregatesJob($reactant, $reaction)
new IncrementReactionAggregatesJob($reactant, $reaction)
);
}
}

0 comments on commit f08741e

Please sign in to comment.