load migrations in provider boot method #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the contribution @raniesantos! Additionally I've extracted loading migrations to protected method, added you to the Contributors List and made a patch release v5.1.1. |
|
it seems that what you did here is now preventing us from using custom migrations, even if we publish the migrations, they are ignored and the ones from the package are migrated instead You would have to do a check to see if the migration exists in the user folder.. but honestly.. I think that a package SHOULD require migrations to be published first.. you were doing it right the first time |
|
Solution details described in #28 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made this PR because Installation instructions don't work as intended.
php artisan migrateshould work without publishing first.