Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional ShouldQueue Behavior v2 #142

Closed
wants to merge 3 commits into from
Closed

Conversation

volkv
Copy link

@volkv volkv commented Feb 4, 2020

There is no need to create separate Listener without ShouldQueue interface. I'm sure there is a way how we could set queue connection to sync on the fly.

That ShouldQueue listeners is a bit tricky, they are not going to IoC container so its not possible to rebind them.
There is a public property $connection but you cant set it on __construct cuz it goes throw
$listener = (new ReflectionClass($class))->newInstanceWithoutConstructor();
The previous approach was a bit straightforward and non-OOP way but it did its job without 'hacks'
This one is another - a bit dirtier, but minimal.
So please choose one or tell your ideas

@antonkomarev
Copy link
Member

Closing in favor of #145 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants