Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract logic from Reactant Listeners to Reactant Jobs #146

Merged
merged 2 commits into from
Feb 8, 2020
Merged

Extract logic from Reactant Listeners to Reactant Jobs #146

merged 2 commits into from
Feb 8, 2020

Conversation

antonkomarev
Copy link
Member

@antonkomarev antonkomarev commented Feb 8, 2020 •
edited
Loading

First part of configurable events behavior concept #145

Extracted logic from Cog\Laravel\Love\Reactant\Listeners\IncrementAggregates listener to Cog\Laravel\Love\Reactant\Jobs\IncrementAggregatesJob

Extracted logic from Cog\Laravel\Love\Reactant\Listeners\DecrementAggregates listener to Cog\Laravel\Love\Reactant\Jobs\DecrementAggregatesJob

@antonkomarev antonkomarev added this to the v8.3.0 milestone Feb 8, 2020
@antonkomarev antonkomarev self-assigned this Feb 8, 2020
@antonkomarev antonkomarev mentioned this pull request Feb 8, 2020
Closed
@antonkomarev antonkomarev merged commit be15cae into master Feb 8, 2020
@antonkomarev antonkomarev deleted the add/increment-and-decrement-aggregates-jobs branch February 8, 2020 12:45
This was referenced Feb 8, 2020
Closed
Merged
@antonkomarev
Copy link
Member Author

Class names were changed in #149

  • IncrementAggregatesJob was renamed do IncrementReactionAggregatesJob
  • DecrementAggregatesJob was renamed do DecrementReactionAggregatesJob

@antonkomarev antonkomarev mentioned this pull request Apr 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@antonkomarev antonkomarev

Labels
enhancement
Projects
None yet
Milestone
v8.3.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@antonkomarev