Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge whereReactedByWithType method to whereReactedBy #89

Merged
merged 3 commits into from
Jul 28, 2019
Merged

Merge whereReactedByWithType method to whereReactedBy #89

merged 3 commits into from
Jul 28, 2019

Conversation

antonkomarev
Copy link
Member

@antonkomarev antonkomarev commented Jul 28, 2019 •
edited
Loading

Reactable model methods

Replace scopeWhereReactedBy & scopeWhereReactedByWithType with single scopeWhereReactedBy method.

Before:

Comment::whereReactedBy(Reactant);
Comment::whereReactedByWithType(Reactant, ReactionType);

After:

Comment::whereReactedBy(Reactant, ?ReactionType);

@antonkomarev antonkomarev added this to the v8.0.0 milestone Jul 28, 2019
@antonkomarev antonkomarev merged commit 8b0f6a9 into master Jul 28, 2019
@antonkomarev antonkomarev deleted the change/merge-where-reacted-by-scope-methods branch July 28, 2019 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v8.0.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@antonkomarev