Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move counters default attributes values to application level #90

Merged
merged 6 commits into from
Jul 29, 2019
Merged

Move counters default attributes values to application level #90

merged 6 commits into from
Jul 29, 2019

Conversation

antonkomarev
Copy link
Member

@antonkomarev antonkomarev commented Jul 29, 2019 •
edited
Loading

Motivation

Make only one place where default attribute values are declared.

Current Implementation

ReactionCounter & ReactionTotal attributes count & weight default values defined on database layer and in $attributes array of the model.

New Implementation

ReactionCounter & ReactionTotal model classes will have constants for each attribute default value:

  • ReactionCounter::DEFAULT_COUNT
  • ReactionCounter::DEFAULT_WEIGHT
  • ReactionTotal::DEFAULT_COUNT
  • ReactionTotal::DEFAULT_WEIGHT

@antonkomarev antonkomarev added this to the v8.0.0 milestone Jul 29, 2019
@antonkomarev antonkomarev changed the title Move counters default values to application level Move counters default attributes values to application level Jul 29, 2019
@antonkomarev antonkomarev merged commit fcefc82 into master Jul 29, 2019
@antonkomarev antonkomarev deleted the change/move-default-counters-values-to-app-layer branch July 29, 2019 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v8.0.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@antonkomarev