Multiple joins for reaction type counts

[jfunulab]

Hey @acidjazz ,
I fixed a use case of mine which I think might be beneficial to the community so I making this pull request.
The current implementation restricted you to only getting only one reaction type count on a reactant at a time with the joinReactionCounterOfType scope. This pr enables you chain multiple scopes of different reaction types to get all their respective counts at once.
Kindly review and let me know if there are any modifications you will like me to make.

[antonkomarev]

@JFunu thank you for the contribution!
I was thinking about ability to add multiple counters at once and planned to return to it as a part of PR #93.

What will happen if developer will add 2 joins with different types and without custom alias?

$likeType = ReactionType::fromName('Like');
$dislikeType = ReactionType::fromName('Dislike');

Comment::query()
  ->joinReactionCounterOfType($likeType)
  ->joinReactionCounterOfType($dislikeType);

I think it should work out of the box by default generating alias from the reaction name. And we could add extra $alias nullable parameter which let developer to skip generation of $alias value.

public function scopeJoinReactionCounterOfType(
    Builder $query,
    ReactionTypeContract $reactionType,
    ?string $alias = null
): Builder {

Then this code will join 2 counters with default aliases:

Comment::query()
  ->joinReactionCounterOfType($likeType)
  ->joinReactionCounterOfType($dislikeType);

And this one will join 2 counters with custom aliases:

Comment::query()
  ->joinReactionCounterOfType($likeType, 'likesCounter')
  ->joinReactionCounterOfType($dislikeType, 'dislikesCounter');

I haven't decided how default alias will look like but it should depend of reaction name for sure, because they are unique.

[jfunulab]

@antonkomarev . Thanks for the feedback. Have implemented the changes.

[antonkomarev]

Looks good! The only one things left to do - add test for join with custom $alias argument and I'm ready to merge it.

[antonkomarev]

Nevermind, I've merged it as is. I will add tests myself in next PR #102.

@JFunu you are in Contributors list now! 🚀

[jfunulab]

Thanks @antonkomarev . My first contribution to open source.

[antonkomarev]

Welcome Aboard! 🥇