Support declarative partitioning #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhances API with "partitions" and "subpartitions" new tables. Add steps in materialize_foreign_table() to support partitioned tables and partitions creation when needed. See README.md for further description. Supports LIST (with default partition), RANGE, HASH and composite partitioning. The last position of a HASH partition is read before partition creation to obtain modulus value. Positions must start at 1.
laurenz
reviewed
Jan 19, 2023
laurenz
reviewed
Jan 19, 2023
laurenz
requested changes
Jan 19, 2023
|
I thought some more about partition boundaries. |
fljdin
force-pushed
the
declarative-partitioning
branch
from
6b6497e
to
d35a9b9
Compare
Reviewed by laurenz
partitions.values and subpartitions.valuess must be arrays depending on partition type Removes position and migrate columns. Related to cybertec-postgresql#12
Use of v_translate_expression inside partitions and subpartitions refresh step. As values represents an array of specification, it loops over unnested values to perform translation before reconstruct array.
|
Ok, I think I have tortured you enough with my complaints, and thanks for your patience. |
|
Good news! All of your suggestions sounded good to me, thanks for your feedback! |
|
Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhances API with "partitions" and "subpartitions" new tables. Add steps in materialize_foreign_table() to support partitioned tables and partitions creation when needed. See README.md for further description.
Supports LIST (with default partition), RANGE, HASH and composite partitioning. The last position of a HASH partition is read before partition creation to obtain modulus value. Positions must start at 1.