Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 'test' support, allows content of responses to be checked #46

Closed
wants to merge 1 commit into from

Conversation

bpytlik
Copy link

@bpytlik bpytlik commented Jul 21, 2015

Abao does a great job of checking the form of the response. For my needs though, I needed to check the content as well. I could have duplicate sets of tests, one for checking the form (in abao) and another for checking the content (not in abao), but that seemed like a waste. I thought adding the ability to check the content within the test would be useful. I hope you agree!

I'm happy to rename the function from 'test' to 'contentTest' or something else similar if you think 'test' will be too confusing.

@cybertk
Copy link
Owner

cybertk commented Jul 21, 2015

Your PR is awesome, could you also have a look on #35. We used to talk about the test feature. And we try to make a brand new and clean syntax for those, but we have not find it yet.

BTW, I think test is good.

@cybertk
Copy link
Owner

cybertk commented Jul 21, 2015

I'm thinking you are using abao to to more things, like arbitrary HTTP testing. It's more like jasmine or something like that. Can we learn some from that?

@bpytlik
Copy link
Author

bpytlik commented Jul 21, 2015

Thanks for the encouragement!

I've been thinking about #35 some while working on this PR.

You're right that I'm using abao to do some more general testing. I'm not familiar with jasmine, but a lot of my recent testing experience has been w/ mocha.

I'll add some thoughts to #35 about what might be the path forward.

@joostmeijles
Copy link

Content testing would indeed be very helpful, when will this be merged in?

@cybertk
Copy link
Owner

cybertk commented Dec 21, 2015

Can someone help rebase this PR?

@bpytlik
Copy link
Author

bpytlik commented Dec 21, 2015

I'm going to be away for about 2 weeks, but I'll probably have time to look at this early in 2016. I'm happy to rebase it if there's a strong chance it'll be taken.

@forrest-ua
Copy link

It would be great! I'm sure the community is waiting for this. Thanks in advance.

@bpytlik
Copy link
Author

bpytlik commented Jan 8, 2016

Closing as I've opened a new PR that is rebased on the current gate tip. It can be found here #63.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants