Implement list command #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yokaze
force-pushed
the
l3-test-setup
branch
4 times, most recently
from
9cf3c38
to
fe67c77
Compare
Signed-off-by: Daichi Sakaue <daichi-sakaue@cybozu.co.jp>
Signed-off-by: Daichi Sakaue <daichi-sakaue@cybozu.co.jp>
yokaze
force-pushed
the
l3-test-setup
branch
2 times, most recently
from
1b951c7
to
d831339
Compare
Signed-off-by: Daichi Sakaue <daichi-sakaue@cybozu.co.jp>
Signed-off-by: Daichi Sakaue <daichi-sakaue@cybozu.co.jp>
chez-shanpu
reviewed
Apr 8, 2024
.github/workflows/ci.yaml
Outdated
| @@ -5,7 +5,7 @@ on: | |||
| branches: | |||
| - main | |||
| env: | |||
| cache-version: 1 | |||
| cache-version: "2024-04-05" | |||
There was a problem hiding this comment.
Why do you use date as cache-version?
And also, I wonder if we need cache-version. Are there any cases that hashFiles is not sufficient?
There was a problem hiding this comment.
@chez-shanpu
It is an old practice to allow invalidating caches when it is contaminated by a broken CI workflow.
However I always hesitate to update the version one: it looks like having a special meaning. Using a date looks more meaningless.
There was a problem hiding this comment.
@yokaze I see. How about deleting a cache like gh cache delete when it is contaminated instead of using cache-version?
There was a problem hiding this comment.
@chez-shanpu
It looks reasonable, I removed the cache-version parameter. Thanks for the info!
Signed-off-by: Daichi Sakaue <daichi-sakaue@cybozu.co.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following four commits:
1. Respect cached files
Fix Makefile and Helm file cache to make them work properly.
2. Run test pods
Deploy some test pods with L3 policies.
self: entry pointingress-explicit-allow: egress fromselfand ingress toingress-explicit-alloware allowedingress-no-rule: egress fromselfis allowed and ingress toingress-no-ruleis implicitly allowed (no rule)ingress-explicit-deny: egress fromselfis allowed but ingress toingress-explicit-denyis explicitly deniedegress-implicit-deny: egress fromselftoegress-implicit-denyis implicitly deniedegress-explicit-deny: egress fromselftoegress-explicit-denyis explicitly denied3. Implement list command
Implement
cilium-policy listthat shows the list of NetworkPolicy applied to a specific pod.Currently the available output format is only
json:simplewill be available in future.Also
cilium-policy dumpis heavily refactored using common helper functions.4. Check go.mod
Just check
go.modis up-to-date.Signed-off-by: Daichi Sakaue daichi-sakaue@cybozu.co.jp