Implement planned features #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Agent implements the body of ep-agent program. It watches etcd and synchronizes users and groups of the running system with the entries in the etcd database. Syncer is an interface that abstracts how it modifies the system users and groups. Implementations will be added but planned ones are: * UbuntuSyncer: uses adduser/addgroup to modify local users/groups. * DummySyncer: do not modify local users/groups, but pretends. * MockSyncer: for tests.
agent/sync.go
Outdated
| }) | ||
| } | ||
|
|
||
| // remove users |
There was a problem hiding this comment.
ユーザの primary group になっている group は消せないので、
remove users は remove groups より前にやった方がよさそう。
$ sudo groupadd aaa
$ sudo groupadd bbb
$ sudo useradd -g aaa -G bbb -m foo
$ id foo
uid=1001(foo) gid=1002(aaa) groups=1002(aaa),1003(bbb)
$ sudo groupdel aaa
groupdel: cannot remove the primary group of user 'foo'
$ sudo groupdel bbb
# supplementary group を消すのは成功する
$ id foo
uid=1001(foo) gid=1002(aaa) groups=1002(aaa)
auth.go
Outdated
| } | ||
|
|
||
| return cmd.CommandContext(ctx, "userdel", "--force", username).Run() | ||
| } |
cmd/etcdpasswd/USAGE.md
Outdated
| - `group remove NAME` | ||
| - `locker list` | ||
| - `locker lock NAME` | ||
| - `locker unlock NAME` |
cli/user.go
Outdated
| f.StringVar(&c.displayName, "display", "", "display name") | ||
| f.StringVar(&c.group, "group", "", "primary group") | ||
| f.Var(&c.groups, "groups", "comma-separated supplementary groups") | ||
| f.StringVar(&c.shell, "shell", etcdpasswd.DefaultShell, "shell program") |
There was a problem hiding this comment.
デフォルトシェルは設定で切り替えられるので、フラグのデフォルト値としては group, groups 同様に空文字列が良いかと。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.