Added proposal to support non-S3 compatible object storage #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymmt2005
reviewed
Dec 21, 2022
| jobConfig: | ||
| ... | ||
| bucketConfig: | ||
| backendType: s3 # added |
There was a problem hiding this comment.
Yes.
I think it is appropriate to default to the S3 API as it has become the de facto standard interface for almost all storage providers.
I'm considering setting the string s3 if empty in the mutating webhook.
There was a problem hiding this comment.
Good. Note also that existing BackupPolicy might have empty backendType,
so MOCO should treat empty as S3.
Signed-off-by: d-kuro <kurosawa7620@gmail.com>
d-kuro
force-pushed
the
d-kuro/storage-type
branch
from
49137a9
to
ab0b7bd
Compare
d-kuro
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #427
Propose API enhancements to allow GCS and other non-S3 compatible object storage to be used from MOCO