Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pmctl not to ignore error. #81

Merged
merged 1 commit into from
Feb 18, 2019
Merged

Fix pmctl not to ignore error. #81

merged 1 commit into from
Feb 18, 2019

Conversation

morimoto-cybozu
Copy link
Contributor

No description provided.

@morimoto-cybozu
Copy link
Contributor Author

list 系のコマンドはエラーにしたくなかったのかも。

@morimoto-cybozu
Copy link
Contributor Author

あ、いや、placemat が起動していなければエラーでいいのか。
起動していて空なら Web API でエラーではなく空が返ってくるから、そのまま表示に進めばいい。

ymmt2005
ymmt2005 approved these changes Feb 18, 2019
View reviewed changes
Copy link
Member

@ymmt2005 ymmt2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ymmt2005 ymmt2005 merged commit 3b10b76 into master Feb 18, 2019
@ymmt2005 ymmt2005 deleted the fix-pmctl branch February 18, 2019 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymmt2005 ymmt2005 ymmt2005 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@morimoto-cybozu @ymmt2005