Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(soy): list all dependency soy files on incremental compilation #1031

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

itchyny
Copy link
Contributor

@itchyny itchyny commented Apr 9, 2024

On incremental compilation, only the changed file is specified for the --srcs flag. However, the closure compiler does not lookup the dependency file  unless they are not specified in --srcs (at least in the current depending version). We are annoyed by the issue that duck aborts the watch mode when a soy file is updated.

@itchyny itchyny requested a review from teppeis as a code owner April 9, 2024 07:26
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 57.70%. Comparing base (2c8095a) to head (99e1a79).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1031      +/-   ##
==========================================
+ Coverage   57.38%   57.70%   +0.31%     
==========================================
  Files          30       30              
  Lines        2971     3000      +29     
  Branches      203      208       +5     
==========================================
+ Hits         1705     1731      +26     
- Misses       1263     1266       +3     
  Partials        3        3              
Files Coverage Δ
src/watch.ts 51.23% <83.33%> (+12.10%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant