Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces Annotation\Attributes with Annotation\NamedArgumentConstructor for all Annotation classes #34

Merged
merged 16 commits into from
Nov 25, 2021

Conversation

butschster
Copy link
Contributor

No description provided.

@butschster butschster added the type:enhancement Enhancement. label Nov 25, 2021
@codecov
Copy link

codecov bot commented Nov 25, 2021

Codecov Report

Merging #34 (d2b7fe3) into 2.0 (e4ae8aa) will decrease coverage by 0.75%.
The diff coverage is 88.23%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.0      #34      +/-   ##
============================================
- Coverage     91.14%   90.39%   -0.76%     
+ Complexity      230      229       -1     
============================================
  Files            22       32      +10     
  Lines           531      552      +21     
============================================
+ Hits            484      499      +15     
- Misses           47       53       +6     
Impacted Files Coverage Δ
src/Annotation/Inheritance.php 33.33% <ø> (ø)
src/Annotation/Inheritance/JoinedTable.php 100.00% <ø> (ø)
src/Annotation/Inheritance/SingleTable.php 100.00% <ø> (ø)
src/Annotation/Relation/Traits/InverseTrait.php 100.00% <ø> (ø)
...Exception/AnnotationWrongTypeArgumentException.php 0.00% <0.00%> (ø)
src/Annotation/Relation/Relation.php 81.81% <33.33%> (-10.49%) ⬇️
src/Configurator.php 83.87% <40.00%> (-2.31%) ⬇️
src/Annotation/Relation/Inverse.php 90.00% <85.71%> (+1.11%) ⬆️
src/Annotation/Column.php 100.00% <100.00%> (ø)
src/Annotation/Embeddable.php 77.77% <100.00%> (-4.05%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 282a793...d2b7fe3. Read the comment docs.

@roxblnfk roxblnfk merged commit 60fc716 into 2.0 Nov 25, 2021
@roxblnfk roxblnfk deleted the feature/303 branch November 25, 2021 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement Enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants