Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unignore src folder #17

Merged
merged 1 commit into from
May 29, 2016
Merged

unignore src folder #17

merged 1 commit into from
May 29, 2016

Conversation

laszlokorte
Copy link
Collaborator

Installing directly from github instead from npm library (for getting the most recent version) does not work because the repo does not contain the lib folder with the compiled js files.

Usually when installing a package from github directly you need to run npm prepublish inside .node_modules/<package>/ your own in order to compile the js sources. (npm/npm#3055)

In case of @cycle/storage the src folder is in npmignore so that installing from github directly gives not neither the src folder nor the lib folder.

I propose removing the src folder vom npm ignore in order to allow fetching the package from github via npm.

But maybe there is a even better solution?

@staltz
Copy link
Member

staltz commented May 29, 2016

Sounds good to me. I'll merge. Thanks Laszlo

@staltz staltz merged commit ad3fa80 into cyclejs:diversity May 29, 2016
@staltz
Copy link
Member

staltz commented May 29, 2016

v3.0.0-rc3 released

@atomrc
Copy link

atomrc commented May 30, 2016

Awesome thanks @laszlokorte

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants