Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installing directly from github instead from npm library (for getting the most recent version) does not work because the repo does not contain the
lib
folder with the compiled js files.Usually when installing a package from github directly you need to run
npm prepublish
inside.node_modules/<package>/
your own in order to compile the js sources. (npm/npm#3055)In case of
@cycle/storage
thesrc
folder is innpmignore
so that installing from github directly gives not neither thesrc
folder nor thelib
folder.I propose removing the
src
folder vom npm ignore in order to allow fetching the package from github via npm.But maybe there is a even better solution?