-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List of supported countries #46
Comments
@mvl22 is this API call available yet? |
We do now have a prototype API call, but we need to implement a few things following a policy discussion last night. Will let you know when this is ready. |
@mvl22 Just skimming through old issues... any update on this? |
Also, after reading https://support.google.com/googleplay/android-developer/answer/7550024?hl=en I was able to find out that we're currently available (according to the Android Play Store) in UK, Ireland, Netherlands & Czech Republic. So when that API call is available and we want to include its information, we also need to make sure we keep those settings in the Developer Console in synch. |
@mvl22 ping |
I've now switched this to be labelled as "Server issue". |
Could you e-mail me about this to remind me to send some more detailed info that I need to check on and I may be able to sort out the thing which has been blocking this. |
NB Is there an Android methodology in terms of country IDs that we can adopt by putting them in our JSON output to enable Store availability automatically? |
Email sent. I think the most important thing is to return the response with a list of standard 2-letter country codes (perhaps in a tuple alongside their user-friendly names). I can't find any evidence of being able to programmatically set the availability, but we might be able to programmatically check the Play Store availability in our builds. The closest I've got in 5 minutes (without having to pay money to anyone) is to hit e.g. https://play.google.com/store/apps/details?id=net.cyclestreets&gl=gb from an incognito browser window; if you then change |
We have an API call which gives a GeoJSON of the exact routeable areas. The ideal is that when the user clicks on a map location in the journey planner in an area that is outside these GeoJSON zones, there should be a modal dialog stating that “Routing is not available in this location.” It would be good if the mechanics for this start to be put in place. |
@mvl22 can you please share details of that "routeable areas" API call - either here or in an email to me? In terms of a list of countries, then, I can see a number of options:
|
@mvl22 ping |
We're still wary of exposing this internal model via the API. However, it occurs to me we could just give a static GeoJSON that is shipped with the app, and periodically update this with new releases. I would be prepared to expedite getting this available. The optimal situation would be:
Would those coders on this ticket be interested to implement that? PS Let's at least manually increase the number of countries in the next main release. Looks like a new release is needed to do that (can't change the existing release). |
@mvl22 I'm happy with an approach roughly along those lines. One change: when you say "The app is available worldwide" I strongly think we should not release it to app stores which don't have full or significant routing coverage, otherwise we're setting ourselves up for terrible reviews. Propose you either email me the current GeoJSON, or commit it to the root |
I think "coders on this ticket" is just me at present 😂 but others are welcome to weigh in! |
@oliverlockwood, imagine this situation. Someone from, say, Mexico goes to the UK for a student exchange programme for a couple of months in Cambridge. They get a bike and want to cycle around, but no, Cyclestreets is not available for them because they still have a Mexican Google account (it is tied to the billing address and you can only change it so many times a year). Does this make any sense to you? The app should detect the location of the user and tell them the routing is not available if it indeed is not available. |
So the only sensible approach in my view is to release the app worldwide. You can’t get rid of bad reviews no matter how hard you try. People will always find things to complain about. |
We got more bad reviews than people asking about making it available. I agree with Oliver on this, after he pointed out that there are of course very large areas with no coverage. I think now the Beta programme is enabled, we can point people to that who get in contact. We can review this once new functionality that provides much better in-app feedback to the user is in place, as things will be different then. |
We now have a public API call for showing the routing coverage: https://www.cyclestreets.net/api/v2/routing.coverage/ By default this will have each feature as an area with a property giving the name. There is also an overlay mode which reverses this, i.e. the routable areas are cut out of a world polygon. This is to enable a overlay that could be clicked on to say routing is not available in that area when a waypoint click is made. If this can be put in then we should be safe to release the app worldwide. |
I suggest the implementation is as follows:
|
An API call will be available shortly giving a list of the countries that the CycleStreets API will route in.
It would be good to list these in the About/Settings area.
The text was updated successfully, but these errors were encountered: