Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up strings, etc. #252

Merged
merged 4 commits into from
Aug 8, 2018
Merged

Tidy up strings, etc. #252

merged 4 commits into from
Aug 8, 2018

Conversation

oliverlockwood
Copy link
Member

@oliverlockwood oliverlockwood commented Aug 8, 2018

This PR:

  1. Removes the Hindu and Marathi translations.
    We only have these as a result of a contribution during Hacktoberfest. The more translations we have, the more effort it is to maintain the app as we continue to refactor and improve. From List of supported countries #46, I strongly suspect that CycleStreets supported locales are not any time soon going to include countries where these are major languages.
  2. Reorganises some string resources. This reduces some duplication between modules, removes translatability of the app name itself (which was never translated!) and will help with subsequent work on the menus, where we need to access some strings in a library instead of the top-level app.
  3. Updates the What's New page according to many recent PRs that have gone in.
  4. Fixes a minor bug where the route highlight buttons stayed around when the route was cleared. Whoops.

@jezhiggins... would you mind doing the honours, please?

Too much effort to maintain and I suspect they're not going to
be major languages in any CycleStreets supported locales
any time soon
@jezhiggins jezhiggins merged commit 917235d into master Aug 8, 2018
@jezhiggins jezhiggins deleted the tidy-up-i18n branch August 8, 2018 09:37
@mvl22
Copy link
Member

mvl22 commented Aug 8, 2018

strongly suspect that CycleStreets supported locales are not any time soon going to include countries where these are major languages

We do actually have coverage of some areas of Asia...

That translation is OK to remove if you want though.

jezhiggins pushed a commit to jezhiggins/cyclestreets-android that referenced this pull request Aug 21, 2018
* Remove Hindu and Marathi

Too much effort to maintain and I suspect they're not going to
be major languages in any CycleStreets supported locales
any time soon

* Update What's New according to many recent changes

* Reorganise some string resources

* Minor bug fix - make sure we always (un)draw the route highlight buttons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants