Use number of commits on branch as the version code #210
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to #179.
The Play store APIs only accept an APK submission if the versionCode (an integer) has not already been used. You can see an example failure here:
Therefore, versionCode has to be monotonically increasing.
The most logical way I could come up with for deriving a monotonically increasing number for our CI builds was to use the number of commits. On the
master
branch (which is the only branch that will attempt to push to the Play store anyway), this number should never go down, assuming that we don't intend to rewrite history.