Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link for "group" is misaligned #673

Closed
roxannedebeaux opened this issue Jan 4, 2017 · 16 comments
Closed

Link for "group" is misaligned #673

roxannedebeaux opened this issue Jan 4, 2017 · 16 comments

Comments

@roxannedebeaux
Copy link

In Firefox on a Mac.

The link for "Group" is now under the search box. Often this gets clicked instead of the search field so this is very annoying.

screen shot 2017-01-04 at 16 58 21

@mvl22
Copy link
Member

mvl22 commented Jan 4, 2017

Note this is happens when a user is a Committee member and thus has 'Membership' added to the menu.

@nikolai-b
Copy link
Contributor

Is this still happening? I can't recreate this in Firefox or Chrome on Linux.

@mvl22
Copy link
Member

mvl22 commented Apr 7, 2017

If you are a committee member and/or an admin, this happens. If you give yourself as many permissions as possible you should see the problem of things not fitting in the menu.

I see this in Chrome on Windows and Mac.

@mvl22
Copy link
Member

mvl22 commented May 4, 2018

@nikolai-b Turns out this one is considered a major issue by some heavy users. Could you prioritise this one?

I guess we might need to respace the menu or something - hopefully you can come with something sensible.

cc @roxannedebeaux

@roxannedebeaux
Copy link
Author

roxannedebeaux commented May 10, 2019 via email

@roxannedebeaux
Copy link
Author

roxannedebeaux commented May 10, 2019 via email

@mvl22
Copy link
Member

mvl22 commented May 10, 2019

As a (ropey) workaround in the meanwhile, you can use tab to progress to the searchbox on the page, and then type in the search term and press return to submit.

@nikolai-b
Copy link
Contributor

I'm confused. On subdomains I don't see the group. Could you include the full URL?

Also I'm able to close the group selector, is this not possible?

group changer

If the change I made doesn't help then I will revert it.

@nikolai-b nikolai-b reopened this May 12, 2019
@mvl22
Copy link
Member

mvl22 commented May 12, 2019

See this screenshot - I've done select-all with the keyboard to highlight the text more clearly. Note the overlay over the search box.

Screen Shot 2019-05-13 at 00 31 44

@roxannedebeaux
Copy link
Author

roxannedebeaux commented May 14, 2019 via email

@nikolai-b
Copy link
Contributor

@mvl22 and @roxannedebeaux I think part of the problem is that I'm not seeing that on my browser.

A simple solution could be to move the search box to the left, would you be happy with this?

At top of page Further down the page
Screenshot from 2019-05-14 20-20-33 Screenshot from 2019-05-14 20-20-48

Also I can add a 0.5 second timeout on the group dropdown so it is only there on hover.

@mvl22
Copy link
Member

mvl22 commented May 14, 2019

If you add the Membership menu entry, that will pretty-much guarantee you experience the problem.

I'm not keen on search being moved. It's in a very standard position, and it's very odd to have it on the left.

If you change

#main-nav nav ul#navigation li a padding from 20px to 15px, that will fix it (except for sysadmins who get the Admin tab, but we can live with that).

I think all the changes in 9a54ae9 can then be discarded.

@mvl22 mvl22 reopened this May 14, 2019
@nikolai-b
Copy link
Contributor

I don't experience any problem (I've selected all to show that the search isn't covered):

Firefox

Chrome

Github has the search on the left, the advantage is that the group selector doesn't interfere with the search at all that way. We could move the group selector to the left instead?

@nikolai-b
Copy link
Contributor

Ah, sorry this is when your on a subdomain only! I see now. I'll fix it.

@nikolai-b
Copy link
Contributor

Most Users: Screenshot from 2019-05-15 21-01-14

Committee: Screenshot from 2019-05-15 21-00-58

Admins: Screenshot from 2019-05-15 21-00-41

@mvl22
Copy link
Member

mvl22 commented May 15, 2019

Thanks; that should do for now until the fuller redesign is sorted out.

nikolai-b added a commit that referenced this issue May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants