Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove remaining modal dialog(s) #901

Closed
mvl22 opened this issue Jan 2, 2020 · 4 comments
Closed

Remove remaining modal dialog(s) #901

mvl22 opened this issue Jan 2, 2020 · 4 comments
Milestone

Comments

@mvl22
Copy link
Member

mvl22 commented Jan 2, 2020

There is currently a very nasty legacy modal dialog remaining, when creating an issue.

This should be replaced with a standard page, containing the same content, as the forthcoming redesign will almost certainly split this out.

This could be at e.g. /issues/<id>/newthread or similar.

Screen Shot 2020-01-02 at 17 41 34

I believe this is the last modal, but if any more are still present, they should similarly be removed.

@mvl22
Copy link
Member Author

mvl22 commented Jan 2, 2020

Ah, our good old friend the Library has one too:

Screen Shot 2020-01-02 at 17 46 51

@mvl22 mvl22 added this to the Tranche 6 milestone Jan 2, 2020
@nikolai-b
Copy link
Contributor

So your suggestion would be to remove the modal and these a new page instead?

@mvl22
Copy link
Member Author

mvl22 commented Jan 7, 2020

Yes, the long New Thread box is practically a great big page already.

nikolai-b added a commit that referenced this issue Jan 16, 2020
nikolai-b added a commit that referenced this issue Jan 16, 2020
@mvl22
Copy link
Member Author

mvl22 commented Jan 17, 2020

All working fine, and good improvement. Please do merge to live.

@nikolai-b nikolai-b mentioned this issue Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants