Make the code base more Go idiomatic #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 31, 2017 11:07
Rename the snake case variables to camel case to follow the Go convention and have more idiomatic Go source code
Remove the constants used to define the HTTP methods and use the ones defined in the standard package net/http.
Rename some variables to have a more contextualized name about the value which they hold
Don't expose GetFuncName because it's a internal helper function
Use the type Values exposed by the standard package net/url for URL parameters than using the generic type map[string]string. Delete unused function which was left out of previous refactor
added 2 commits
January 31, 2017 12:35
Rename Auth0 constructor function following Go naming conventions
Adapt README to the new refactoring, idiomatize code examples and fix typos
ifraixedes
force-pushed
the
if-idiomatize
branch
from
f684743
to
c2a60a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made several changes in the code base to have it more Go idiomatic.
Be aware that they introduce breaking changes, because of the:
constused to represent theHTTPmethodsmap[string]stringtourl.ValuesBecause of the changes, this PR should close #8 because the issue isn't currently about the feature expressed in the title is regarding a bug which should be fixed by PR #9 which is waiting for a review however this PR should close without the need of being merged.