aws: new resources #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talset
force-pushed
the
fl-awsresources
branch
2 times, most recently
from
09cbd9d
to
cb107ac
Compare
talset
added
Status: Need review
Type: Enhancement
xescugc
requested changes
Mar 18, 2020
| @@ -34,6 +34,16 @@ var ( | |||
| // Returned values are commented in the interface doc comment block. | |||
| `, | |||
| }, | |||
| Function{ | |||
| Entity: "VpcPeeringConnections", | |||
There was a problem hiding this comment.
Should it maybe be named VPC..?
There was a problem hiding this comment.
I took the format from https://github.com/cycloidio/terracognita/blob/master/aws/cmd/functions.go#L29
Should we change both to VPC ?
There was a problem hiding this comment.
Ok nothing, this is the one used on their side, it's ok :).
aws/resources.go
Outdated
| } | ||
| } | ||
|
|
||
| //TODO: This resource it's not Importable yet (https://www.terraform.io/docs/providers/aws/r/lb_listener_certificate.html) |
There was a problem hiding this comment.
I would add an issue and link it to this so we know/remember this if at somepoint it's importable.
If not, maybe we do not need this function as it has no use hehe.
|
PR updated |
|
yes I'm reverting VPCPeeringConnections to VpcPeeringConnections but I failed somewhere :) |
aws_alb_listener aws_alb_target_group aws_alb_listener_rule aws_alb_listener_certificate (not importable yet)
Generate aws/reader/reader.go
aws/resourcetype_enumer.go
xescugc
approved these changes
Mar 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement new AWS resources