Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assert correct URLs #35

Closed
jkowalleck opened this issue Dec 2, 2021 · 1 comment · Fixed by #34
Closed

assert correct URLs #35

jkowalleck opened this issue Dec 2, 2021 · 1 comment · Fixed by #34
Assignees
@jkowalleck
Labels
bug Something isn't working

Comments

@jkowalleck
Copy link
Member

jkowalleck commented Dec 2, 2021 •
edited
Loading

caused by CycloneDX/cyclonedx-php-composer#158

have all the XML strings that are anyURI somehow fixed before rendering the XML.
affected elements:

  • component.purl
  • license.url
  • externalReterence.url
  • and so on ...

according to XML spec the anyURI needs to conform to https://www.ietf.org/rfc/rfc2396.txt

 * @see http://www.w3.org/TR/xmlschema-2/#anyURI
 * @see http://www.datypic.com/sc/xsd/t-xsd_anyURI.html


    /* URIs require that some characters be escaped with their hexadecimal Unicode code point preceded by the %
     * character. This includes non-ASCII characters and some ASCII characters, namely control characters, spaces,
     * and the following characters (unless they are used as deliimiters in the URI): <>#%{}|\^`.
     * [...]
     * The only values that are not accepted are ones that make inappropriate use of reserved characters, such as ones that contain multiple # characters or have % characters that are not followed by two hexadecimal digits.
     * -- as of http://www.datypic.com/sc/xsd/t-xsd_anyURI.html
     */
@jkowalleck jkowalleck self-assigned this Dec 2, 2021
@jkowalleck jkowalleck mentioned this issue Dec 2, 2021
Merged
2 tasks
@jkowalleck jkowalleck added the bug Something isn't working label Dec 2, 2021
@jkowalleck jkowalleck mentioned this issue Dec 2, 2021
Closed
@jkowalleck jkowalleck pinned this issue Dec 2, 2021
@jkowalleck
Copy link
Member Author

jkowalleck commented Dec 2, 2021 •
edited
Loading

maybe caused by: #19
related by: #18

jkowalleck added a commit that referenced this issue Dec 2, 2021
@jkowalleck
fix XML encoding for anyURI
7a3e0b8 
related to #35
jkowalleck added a commit that referenced this issue Dec 2, 2021
@jkowalleck
fix XML encoding for anyURI
bea9fd0 
related to #35
jkowalleck added a commit that referenced this issue Dec 2, 2021
@jkowalleck
fix XML encoding for anyURI
85c4349 
related to #35
jkowalleck added a commit that referenced this issue Dec 3, 2021
@jkowalleck
fix XML encoding for anyURI
5a746b4 
related to #35
jkowalleck added a commit that referenced this issue Dec 3, 2021
@jkowalleck
fix XML encoding for anyURI
98865e4 
related to #35

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
jkowalleck added a commit that referenced this issue Dec 3, 2021
@jkowalleck
fix XML encoding for anyURI
62e615e 
related to #35

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck unpinned this issue Dec 4, 2021
@jkowalleck jkowalleck mentioned this issue Dec 2, 2023
Closed
@jkowalleck jkowalleck changed the title XML anyURI escape/fix on rendereing assert correct URLs Dec 2, 2023
This was referenced Dec 2, 2023
Closed
Merged
jkowalleck added a commit that referenced this issue Dec 2, 2023
@jkowalleck
feat: migrate urls when normalizing to JSON (#380)
3b5482a 
migrate/fixup URLs when normalizing to JSON

followup of #35 

---------

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jkowalleck jkowalleck

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix possible XML anyURI violations CycloneDX/cyclonedx-php-library
1 participant
@jkowalleck