Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no module found on search #287

Merged
merged 6 commits into from
May 23, 2024
Merged

no module found on search #287

merged 6 commits into from
May 23, 2024

Conversation

AKHIL-DyC
Copy link
Contributor

closes #286

📑 Description

✅ Checks

  • [ ✅] I have updated the documentation as required
  • [ ✅] I have performed a self-review of my code

ℹ Additional context

@AKHIL-DyC AKHIL-DyC requested a review from a team as a code owner May 21, 2024 21:19
@petar-cvit
Copy link
Collaborator

@AKHIL-DyC I agree with the proposal, it should be clear that there were no modules found. Can we use this instead of the card?

@petar-cvit
Copy link
Collaborator

Can you center it in the middle of the screen? Also, I would remove the button since there already is one in the upper right corner and it might confuse.

Screenshot 2024-05-22 at 17 06 40

@AKHIL-DyC
Copy link
Contributor Author

@petar-cvit changes made

Co-authored-by: Petar Cvitanović <72022639+petar-cvit@users.noreply.github.com>
@AKHIL-DyC AKHIL-DyC requested a review from petar-cvit May 22, 2024 17:56
Copy link
Collaborator

@petar-cvit petar-cvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AKHIL-DyC

@petar-cvit petar-cvit merged commit e6e862c into cyclops-ui:main May 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When searching for deployed modules ,show
2 participants