-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render road ref along them, smaller cycle route shield, cleaning #233
Conversation
Render cycle route junction node from z13 instead of z11 (too many of them in netherlands, useless at that zoom).
} | ||
} | ||
|
||
#roads-text-ref { | ||
[highway = 'motorway_trunk'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The two of them were merged https://github.com/cyclosm/cyclosm-cartocss-style/blob/master/project.mml#L2011 in SQL queries. We should either keep motorway_trunk
or drop the merge in roads-text-ref
SQL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don’t remind to have done that change, must come from the copy past I have done to write that layer from name layer.
@@ -629,6 +521,7 @@ | |||
shield-face-name: @sans; | |||
shield-clip: @shield-clip; | |||
shield-file: url("symbols/shields/[type]_[width]x[height].svg"); | |||
shield-transform: "scale(0.75)"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather edit the script https://github.com/cyclosm/cyclosm-cartocss-style/blob/master/scripts/generate_shields.py to generate shield the right size. I'll handle this after this PR has been merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried, I failed 😭
👍 We have a bit of readability issues at low zooms (city or less). https://cyclosm.org/#13/48.8779/2.2867 |
May be, not sure, +1 to the font size ? |
link to #197