Deprecate ResourceBuff
#604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Build Status Report - 72ccbab - 2024-05-17 12:12:27 -0500Build
|
gonuke
requested changes
May 17, 2024
| @@ -318,7 +318,6 @@ void Storage::ProcessMat_(double cap) { | |||
| using cyclus::Material; | |||
| using cyclus::ResCast; | |||
| using cyclus::toolkit::ResBuf; | |||
| using cyclus::toolkit::Manifest; | |||
There was a problem hiding this comment.
While we're here... I don't see any reason for any of these using statements to be here...?
There was a problem hiding this comment.
Great point. I went through storage.cc and cleaned up some other using statements. A quick search of the cycamore archetypes shows there are a lot of using statements throughout the repo. I will make an issue to go through and clean up where it is necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small change to allow for the removal of the
ResourceBuffclass in cyclus