limit PR conditions for running this workflow #1602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your changes look good. However, the workflows are failing the cyclus_unit_tests (SymbolicFunctionTests.expfunc, specifically). There must be a problem elsewhere, since your changes shouldn't affect whether the tests pass or fail. What is best practice here? |
|
Best practice seems to be rerunning the tests (not really best practice!). I noticed this when I was setting up these workflows and this particular test fails randomly and/or 1/2 the time... so that's another bug to track down? |
bennibbelink
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only run the publish workflow on PRs that have changes in specific files.
Fixes #1600
(replaces #1601 with local branch)