-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Code Coverage using Coveralls #1616
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I think we need to merge this to properly understand how it interacts with coveralls
I think we need to resolve the CHANGELOG merge conflict |
Signed-off-by: bennibbelink <79653949+bennibbelink@users.noreply.github.com>
I addressed the merge conflict. I agree, I'm not entirely sure what needs to happen for the chat-bot to work. At the very least this puts the coverage infrastructure in place and we can play around with the different features that coveralls provides |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging now
Adds a build option to enable code coverage and generates coverage reports in the
build_test.yml
workflow.The workflows will generate html artifacts that can be downloaded and push coverage reports to Coveralls. The settings in Coveralls allow us to define failure thresholds for PRs.
Fixes #1591