Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Code Coverage using Coveralls #1616

Merged
merged 9 commits into from
Nov 29, 2023
Merged

Conversation

bennibbelink
Copy link
Contributor

@bennibbelink bennibbelink commented Nov 12, 2023

Adds a build option to enable code coverage and generates coverage reports in the build_test.yml workflow.

The workflows will generate html artifacts that can be downloaded and push coverage reports to Coveralls. The settings in Coveralls allow us to define failure thresholds for PRs.

Fixes #1591

@bennibbelink bennibbelink linked an issue Nov 12, 2023 that may be closed by this pull request
@bennibbelink bennibbelink marked this pull request as ready for review November 27, 2023 16:41
Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I think we need to merge this to properly understand how it interacts with coveralls

@gonuke gonuke added the Infrastructure: CI Related to automated testing as part of continuous integration label Nov 29, 2023
@gonuke
Copy link
Member

gonuke commented Nov 29, 2023

I think we need to resolve the CHANGELOG merge conflict

Signed-off-by: bennibbelink <79653949+bennibbelink@users.noreply.github.com>
@bennibbelink
Copy link
Contributor Author

I addressed the merge conflict.

I agree, I'm not entirely sure what needs to happen for the chat-bot to work. At the very least this puts the coverage infrastructure in place and we can play around with the different features that coveralls provides

Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging now

@gonuke gonuke merged commit 795fb8a into cyclus:main Nov 29, 2023
11 checks passed
@bennibbelink bennibbelink deleted the coveralls branch December 6, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure: CI Related to automated testing as part of continuous integration
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

introduce code coverage measurement to CI
2 participants