Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmake updates and python installation best practices #1632

Merged
merged 26 commits into from Dec 6, 2023
Merged

Conversation

bennibbelink
Copy link
Contributor

This includes lots of minor cmake changes and attempts to use modern python best practices for installing cyclus' python package

The apt-20.04 build_test.yml fails because the dependency images don't have pip installed, but it passes in the build_test_publish.yml. Should I make a separate PR to add pip as a dependency, then address this PR so the workflows pass?

@bennibbelink
Copy link
Contributor Author

#1633 will add pip as a dependency, then these workflows should pass on the new images

@coveralls
Copy link
Collaborator

coveralls commented Dec 1, 2023

Pull Request Test Coverage Report for Build 7061291662

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.001%) to 49.335%

Files with Coverage Reduction New Missed Lines %
src/pyinfile.cc 9 48.94%
Totals Coverage Status
Change from base Build 7027753240: -0.001%
Covered Lines: 23971
Relevant Lines: 41349

💛 - Coveralls

@bennibbelink bennibbelink marked this pull request as ready for review December 6, 2023 16:42
@bennibbelink bennibbelink mentioned this pull request Dec 6, 2023
Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bennibbelink

@gonuke gonuke merged commit faf695a into main Dec 6, 2023
15 checks passed
@bennibbelink bennibbelink deleted the cmake-updates branch February 7, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants