Cython3 upgrade #1636
Merged
Cython3 upgrade #1636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that the version of cython installed by apt is still 0.29.x |
Pull Request Test Coverage Report for Build 7531607762
💛 - Coveralls |
bennibbelink
force-pushed
the
cython3-upgrade
branch
from
335ccc7
to
a655a4d
Compare
bennibbelink
force-pushed
the
cython3-upgrade
branch
from
a655a4d
to
9ea2a51
Compare
|
A ton of warnings still from the cython compiler. Looking into resolutions... |
bennibbelink
force-pushed
the
cython3-upgrade
branch
from
44f7ca2
to
77b236e
Compare
gonuke
requested changes
Jan 15, 2024
bennibbelink
force-pushed
the
cython3-upgrade
branch
from
d38c58d
to
4aacd52
Compare
gonuke
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the pin on cython in cyclus, and we now see the same behavior with cython3.0.6 as we did in 0.29.x. Unfortunately it did not magically solve the issues discussed in #1589, so there is still some work to be done there
This has been branched off of
cmake-updates, so I propose we resolve any needed revisions in #1632 and get that merged first to make this PR more readable