Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding custom BrightLite tables to root metrics list #52

Merged
merged 1 commit into from
Apr 29, 2015

Conversation

opotowsky
Copy link
Member

No description provided.

@gidden
Copy link
Member

gidden commented Apr 15, 2015

I'm curious what our policy is for directly supporting 3rd party archetypes in our tooling ecosystem. Most of our tools to date allow for discovery, rather than explicit support.

This PR (to the best of my understanding) would be the first such explicit support, and thus would set a precedent. Accordingly, I think we should think about/declare what criteria exist for explicitly supporting 3rd party archetypes.

@opotowsky
Copy link
Member Author

This is something I would like to fix in the future (post-semester), but since this still unstable code maybe we can let it slide for now?

Two options moving forward:

  1. generalize: make an issue to add the capability in cymetric to look up "root metrics" in each database
  2. consider this a user task, since we want users to write their own metrics anyway. (this would mean we shouldn't merge in the Bright-Lite stuff though)

@scopatz scopatz merged commit aa56acc into cyclus:master Apr 29, 2015
@scopatz
Copy link
Member

scopatz commented Apr 29, 2015

Thanks @opotowsky!

@opotowsky opotowsky deleted the brightroots branch May 5, 2015 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants