Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support transform defineProps's and defineEmits's types to parameters #11

Merged
merged 2 commits into from
Dec 30, 2023

Conversation

Dunqing
Copy link
Contributor

@Dunqing Dunqing commented Sep 20, 2023

Just removing all the types from vue will result in missing props and emits. This PR will transform types into parameters

More about refer to radix-vue/shadcn-vue#62

@zernonia
Copy link

Thanks @Dunqing ! There's also a bug where Nuxt project couldn't infer type for defineProps really well.. do you think this transfom method would solve it too?

radix-vue/shadcn-vue#70

@Dunqing
Copy link
Contributor Author

Dunqing commented Sep 22, 2023

Thanks @Dunqing ! There's also a bug where Nuxt project couldn't infer type for defineProps really well.. do you think this transfom method would solve it too?

radix-vue/shadcn-vue#70

Seems like can't solve, That issue typescript version was used.

@cyco130
Copy link
Owner

cyco130 commented Dec 30, 2023

Hi,

Sorry for very late response. I know little about Vue but I'm happy as long as the tests pass :)

Will release a new version soon.

@cyco130 cyco130 merged commit 2058301 into cyco130:main Dec 30, 2023
6 checks passed
@cyco130
Copy link
Owner

cyco130 commented Dec 30, 2023

Released as 1.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants