Update abstreet scenario generation code to work with latest versions of abstr package

[Robinlovelace]

Currently this will fail using the latest versions of abstr:

actdev/code/abstr-scenarios.R

Lines 242 to 249 in e528051

	abc = abstr::ab_scenario(
	houses,
	buildings = buildings_in_zones,
	desire_lines = desire_lines %>% filter(purpose == "commute" & all_base > 0),
	zones = zones_of_interest,
	scenario = "base",
	output_format = "sf"
	)

Good news: the latest version of that package will work with origin and destination zones. As documented in https://a-b-street.github.io/abstr/reference/ab_scenario.html the following preprocessing steps enable the input data to work with the new and improved version of abstr:

od = leeds_desire_lines
names(od)[8:10] = c("Walk", "Bike", "Drive")
ablines_dutch = ab_scenario(
  od = od,
  zones = leeds_site_area,
  zones_d = leeds_zones,
  origin_buildings = leeds_houses,
  destination_buildings = leeds_buildings,
  output = "sf"
)

You up for giving this one a bash up some point @natesheehan ? Sorry it's been a bit convoluted: involved various upstream fixes in od, the dev version of which now has the necessary changes.

[natesheehan]

Nice work Robin! thanks for documenting this, I have taken a look this morning and it seems things are running ok. However in playing around, I have found an issue (#179) with some of our desire_line datasets. This should be fixed by rerunning the dev script for the effected sites.

[Robinlovelace]

Great work @natesheehan. Consoling myself on the ⚽ result with some coding 🤓

[Robinlovelace]

I think this is fixed now, right @natesheehan ? Please close if so!

[natesheehan]

Yes this is now working! So lets close this ticket, and today I will rerun the build script re #179