refactor: do not subclass by default #120
Conversation
cyjake
commented
Jun 24, 2021
cyjake
commented
- gather around glue code for legacy timestamp
- gather around glue code for legacy timestamp
| assert.equal(arda.Bone, Bone); | ||
|
|
||
| const realm = new Realm({ subclass: true }); | ||
| assert.ok(realm.Bone.prototype instanceof Bone); |
There was a problem hiding this comment.
egg-orm will turn opts.subclass on by default, which (theoretically) makes connecting to multiple databases simultaneously possible.
There was a problem hiding this comment.
subclass is not easy to understand, how about change another name, for example: singleConnection?
There was a problem hiding this comment.
There always is only one connection pool for realm instance. When multiple datasources is specified in egg-orm, egg-orm tries to instantiate multiple realms to retain multiple connection pools with the config specified in datasources array.
We made this possible by subclassing Bone. But this feature is seldom used (at least for now) hence I intend to not make this the default behavior.
| if (opts.sequelize) return sequelize(Bone); | ||
| if (opts.subclass !== true) return Bone; |
There was a problem hiding this comment.
For simple cases, Bone is not required to be subclassed to possess connection to database. Most of the time, the connection pool is shared at process level. By shortening prototype lookup chain, we can make function calls on Bone.prototype faster a bit.
