Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR template update. #3178

Merged
merged 3 commits into from May 24, 2019
Merged

PR template update. #3178

merged 3 commits into from May 24, 2019

Conversation

hjoliver
Copy link
Member

Tweak the new PR template, to make it clear that some PRs don't require accompanying tests or a change log entry. While I was at it, made the wording a little more concise.

@hjoliver hjoliver self-assigned this May 22, 2019
Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One typo only I think. Otherwise looks good to me

.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
@hjoliver hjoliver requested a review from MartinRyan May 22, 2019 19:58
Copy link
Contributor

@MartinRyan MartinRyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line "COMMENT: Mark the PR as a Draft if not all are satisfied just yet." could possibly be changed to "COMMENT: Mark the PR as a Draft if all requirements are not yet satisfied".

@hjoliver
Copy link
Member Author

@MartinRyan - done.

@MartinRyan MartinRyan merged commit 8d622d9 into cylc:master May 24, 2019
@hjoliver hjoliver deleted the PR-template-update branch May 24, 2019 11:35
@matthewrmshin matthewrmshin added this to the cylc-8.0a1 milestone Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants