Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR template update. #3178

Merged
merged 3 commits into from May 24, 2019
Merged

PR template update. #3178

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1af13b1
PR template update.
hjoliver May 22, 2019
9a90297
Fix typo.
hjoliver May 22, 2019
269daa9
Address feedback.
hjoliver May 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 11 additions & 8 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
@@ -1,16 +1,19 @@
COMMENT: Complete this Pull Request template and delete all "COMMENT:" lines.

COMMENT: Significant PRs should address an existing Issue. Choose one of:
COMMENT: Significant PRs should address an existing Issue. Choose one:
These changes partially address #xxxx
These changes close #xxxx
This is a small change with no associated Issue.

COMMENT: The following requirements must be satisfied, now or before merge.
COMMENT: The following requirements must be satisfied (with "[x]").
COMMENT: Mark the PR as a Draft if not all are satisfied just yet.
Requirements check-list:
**Requirements check-list**
- [ ] I have read `CONTRIBUTING.md` and added my name as a Code Contributor.
- [ ] My commits have logically grouped changes (use interactive rebase
to tidy your branch history if necessary).
- [ ] I have not included off-topic changes (use other PRs for these).
- [ ] I have included tests with adequate coverage.
- [ ] I have added an entry in `CHANGES.md` for next release.
- [ ] Constains logically grouped changes (else tidy your branch by rebase).
hjoliver marked this conversation as resolved.
Show resolved Hide resolved
- [ ] Does not contain off-topic changes (use other PRs for other changes).
COMMENT: choose one:
- [ ] Appropriate tests are included (unit and/or functional).
- [ ] These changes are already covered by existing tests.
COMMENT: choose one:
- [ ] Includes an appropriate entry in the release change log `CHANGES.md`.
- [ ] No change log entry required (e.g. change is small or internal only).