Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[[dependencies]] => [[graph]] #3272

Merged
merged 3 commits into from
Aug 6, 2019
Merged

[[dependencies]] => [[graph]] #3272

merged 3 commits into from
Aug 6, 2019

Conversation

matthewrmshin
Copy link
Contributor

@matthewrmshin matthewrmshin commented Aug 5, 2019 •
edited
Loading

These changes follows #3191. Move the old [scheduling][[dependencies]] section to [scheduling][[graph]] in suite.rc. Improve support for async graphs.

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Already covered by existing tests.
  • Appropriate change log entry included.

@matthewrmshin matthewrmshin added this to the cylc-8.0a2 milestone Aug 5, 2019
@matthewrmshin matthewrmshin self-assigned this Aug 5, 2019
@matthewrmshin matthewrmshin marked this pull request as ready for review August 5, 2019 19:50
@cylc cylc deleted a comment Aug 5, 2019
hjoliver
hjoliver approved these changes Aug 5, 2019
View reviewed changes
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; tests all passing; thanks @matthewrmshin 👍

dwsutherland
dwsutherland approved these changes Aug 6, 2019
View reviewed changes
Copy link
Member

@dwsutherland dwsutherland left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I'll change the test suites in the GraphQL merged and PR afterwards

@hjoliver
Copy link
Member

hjoliver commented Aug 6, 2019

Thanks for the review @dwsutherland . I don't think we need to wait on @oliver-sanders to review this. It's a straightforward change, in spite of this size of it.

@hjoliver hjoliver merged commit 208cd0e into cylc:master Aug 6, 2019
@matthewrmshin matthewrmshin modified the milestones: cylc-8.0a2, cylc-8.0a1 Aug 6, 2019
@matthewrmshin matthewrmshin deleted the more-async-graph branch August 6, 2019 08:46
This was referenced Aug 6, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjoliver hjoliver hjoliver approved these changes

@dwsutherland dwsutherland dwsutherland approved these changes

@oliver-sanders oliver-sanders Awaiting requested review from oliver-sanders

Assignees

@matthewrmshin matthewrmshin

Labels
None yet
Projects
None yet
Milestone
cylc-8.0a1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matthewrmshin @hjoliver @dwsutherland