-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated release process and auto update copyright year #3937
Conversation
This comment has been minimized.
This comment has been minimized.
Sounds great 👍 But can you explain how it works, to save me from a bit of time-consuming reverse-engineering? (e.g. what triggers the new release action?) |
Essentially:
The instructions (currently in a draft PR) on cylc-admin: https://github.com/cylc/cylc-admin/blob/e5db64f73168cb639cc739b8fcb08a8a3dd34a5a/docs/howto/create-a-release.md |
Is there a way to dry-run test this @MetRonnie ? (Take a branch and disable the publish bit, I suppose?) |
Can clone the repo and add a |
Could add switch to publish to the pypi test repo. |
prerelease: true | ||
prerelease: ${{ env.PRERELEASE }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now possible due to cylc/release-actions#6
uses: pypa/gh-action-pypi-publish@v1.4.1 | ||
with: | ||
user: __token__ # uses the API token feature of PyPI - least permissions possible | ||
password: ${{ secrets.PYPI_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can use this to test without risking the cylc-flow package.
password: ${{ secrets.PYPI_TOKEN }} | |
password: ${{ secrets.PYPI_TOKEN }} | |
repository_url: https://test.pypi.org/legacy/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe document this in the file @MetRonnie ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to push ahead with this as for other repos. Happy to create the token. Can test this out on the PyPi test repo if being cautious.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What @oliver-sanders said 👍
Not merging in case you want to add a comment as suggested above. And the token isn't done (can you do that Oliver, if you already now how?)
We can wait until trying out the same release process on cylc-sphinx-extensions for 1.3.0, likely to be today |
for the create GitHub release step
Forgot to undraft this. Just rebased to fix merge conflict |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Demo run here - MetRonnie#4 |
This is a small change with no associated Issue.
Needs:
Requirements check-list
CONTRIBUTING.md
and added my name as a Code Contributor.