Jupyter server

[oliver-sanders]

Small changes required for cylc/cylc-uiserver#230

Requirements check-list

• I have read CONTRIBUTING.md and added my name as a Code Contributor.
• Contains logically grouped changes (else tidy your branch by rebase).
• Does not contain off-topic changes (use other PRs for other changes).
• Applied any dependency changes to both setup.py and
  conda-environment.yml.
• Does not need tests (why?).
• No change log entry required (why? e.g. invisible to users).
• docs: architecture reference docs cylc-doc#285

[kinow]

Looks good to me, but functional tests failing.

[13:51:13] tests/functional/job-file-trap/00-sigusr1.t ........... skipped: TODO decide whether to re-instate this
[13:51:19] tests/functional/job-file-trap/02-pipefail.t .......... 
/usr/bin/lsof
1..6
INSTALLED cylctb-20210803T135111Z-pC4F/functional/job-file-trap/02-pipefail from /tmp/tmp.Ng6tAGu0RN/cylctb-20210803T135111Z-pC4F/functional/job-file-trap/02-pipefail
ok 1 - 02-pipefail-validate-validate
ok 2 - 02-pipefail-run
ok 3 - job.status-contains-ok
ok 4 - grep-ok: job.status-grep-ok
ok 5 - job.status-contains-ok
ok 6 - grep-ok: job.status-grep-ok
ok     7222 ms ( 0.01 usr  0.00 sys +  3.76 cusr  0.71 csys =  4.48 CPU)
[13:51:25] tests/functional/job-file-trap/03-user-trap.t ......... 
/usr/bin/lsof
1..5
INSTALLED cylctb-20210803T135111Z-pC4F/functional/job-file-trap/03-user-trap from /tmp/tmp.t1wkoIqg5R/cylctb-20210803T135111Z-pC4F/functional/job-file-trap/03-user-trap
ok 1 - 03-user-trap-validate
ok 2 - 03-user-trap-run
CYLC_JOB_PID=432
ok 3 - grep-ok: job.status-grep-ok
ok 4 - job.testout-grep-fail
Exit with code 143
ok 5 - job.testout-cmp-ok
ok    12512 ms ( 0.00 usr  0.01 sys +  4.75 cusr  0.90 csys =  5.66 CPU)
[13:51:35] tests/functional/events/28-inactivity.t ............... 
/usr/bin/lsof
1..3
INSTALLED cylctb-20210803T135111Z-pC4F/functional/events/28-inactivity from /tmp/tmp.iqEXMSQkHH/cylctb-20210803T135111Z-pC4F/functional/events/28-inactivity
ok 1 - 28-inactivity-validate
ok 2 - 28-inactivity-run
ok 3 - grep-ok: 28-inactivity-run.stderr-grep-ok
ok    16258 ms ( 0.00 usr  0.00 sys +  4.78 cusr  0.85 csys =  5.63 CPU)
[13:51:40] tests/functional/shutdown/14-no-dir-check.t ........... 
/usr/bin/lsof
1..3
INSTALLED cylctb-20210803T135111Z-pC4F/functional/shutdown/14-no-dir-check from /tmp/tmp.clUf81ktkW/cylctb-20210803T135111Z-pC4F/functional/shutdown/14-no-dir-check
ok 1 - 14-no-dir-check-validate
ok 2 - 14-no-dir-check-run
ok 3 - grep-ok: log.20210803T135128Z-grep-ok
ok    14720 ms ( 0.01 usr  0.00 sys +  5.59 cusr  0.99 csys =  6.59 CPU)
[13:51:56] tests/functional/cylc-poll/15-job-st-file-no-batch.t .. 
/usr/bin/lsof
1..4
INSTALLED cylctb-20210803T135111Z-pC4F/functional/cylc-poll/15-job-st-file-no-batch from /tmp/tmp.OVOw01TiZF/cylctb-20210803T135111Z-pC4F/functional/cylc-poll/15-job-st-file-no-batch
ok 1 - 15-job-st-file-no-batch-validate
ok 2 - 15-job-st-file-no-batch-run
ok 3 - 15-job-st-file-no-batch-log-1
ok 4 - 15-job-st-file-no-batch-log-2
ok    21206 ms ( 0.00 usr  0.00 sys +  5.76 cusr  1.02 csys =  6.78 CPU)

    stdout and stderr stored in: /tmp/root/cylctb-20210803T135111Z-pC4F/functional/shutdown/09-now2
    workflow logs can be found under: /root/cylc-run/cylctb-20210803T135111Z-pC4F/functional/shutdown/09-now2/log/workflow/
[13:52:01] tests/functional/shutdown/09-now2.t ................... 
/usr/bin/lsof
1..9
INSTALLED cylctb-20210803T135111Z-pC4F/functional/shutdown/09-now2 from /tmp/tmp.QniJxKqvWc/cylctb-20210803T135111Z-pC4F/functional/shutdown/09-now2
ok 1 - 09-now2-validate
not ok 2 - 09-now2-run
not ok 3 - grep-ok: log-grep-ok
ok 4 - grep-ok: log-grep-ok
ok 5 - grep-ok: log-grep-ok
ok 6 - 09-now2-activity-log-succeeded
not ok 7 - 09-now2-activity-log-started
ok 8 - t2-file-exists-fail
ok 9 - 09-now2-restart
Failed 3/9 subtests 
[13:52:15] tests/functional/pause-resume/12-pause-then-retry.t ... 
/usr/bin/lsof
1..2
INSTALLED cylctb-20210803T135111Z-pC4F/functional/pause-resume/12-pause-then-retry from /tmp/tmp.w6Gna76eRP/cylctb-20210803T135111Z-pC4F/functional/pause-resume/12-pause-then-retry
ok 1 - 12-pause-then-retry-validate
ok 2 - 12-pause-then-retry-run
ok    19185 ms ( 0.00 usr  0.01 sys +  7.31 cusr  1.33 csys =  8.65 CPU)
[13:52:17] tests/functional/shutdown/13-no-port-file-check.t ..... 
/usr/bin/lsof
1..3
INSTALLED cylctb-20210803T135111Z-pC4F/functional/shutdown/13-no-port-file-check from /tmp/tmp.OMkzwNHYBY/cylctb-20210803T135111Z-pC4F/functional/shutdown/13-no-port-file-check
ok 1 - 13-no-port-file-check-validate
ok 2 - 13-no-port-file-check-run
ok 3 - grep-ok: log-grep-ok
ok    15943 ms ( 0.00 usr  0.01 sys +  6.61 cusr  1.23 csys =  7.85 CPU)
[13:52:23] tests/functional/jobscript/00-torture.t ............... 
/usr/bin/lsof
1..2
INSTALLED cylctb-20210803T135111Z-pC4F/functional/jobscript/00-torture from /tmp/tmp.9r1gECXUlZ/cylctb-20210803T135111Z-pC4F/functional/jobscript/00-torture
ok 1 - 00-torture-validate
ok 2 - 00-torture-run
ok     7316 ms ( 0.00 usr  0.00 sys +  5.93 cusr  1.15 csys =  7.08 CPU)
[13:52:29] tests/functional/events/34-task-abort.t ............... 
/usr/bin/lsof
1..6
INSTALLED cylctb-20210803T135111Z-pC4F/functional/events/34-task-abort from /tmp/tmp.NcKKLIowOW/cylctb-20210803T135111Z-pC4F/functional/events/34-task-abort
ok 1 - 34-task-abort-validate
ok 2 - 34-task-abort-run
ok 3 - edited-job-activity.log-cmp-ok
ok 4 - grep-ok: job.out-grep-ok
ok 5 - job.out-grep-fail
ok 6 - 34-task-abort-message-count
ok    12185 ms ( 0.00 usr  0.01 sys +  6.02 cusr  1.16 csys =  7.19 CPU)
[13:52:41] tests/functional/cylc-poll/11-event-time.t ............ 
/usr/bin/lsof
1..3
INSTALLED cylctb-20210803T135111Z-pC4F/functional/cylc-poll/11-event-time from /tmp/tmp.9nlvQuGR3P/cylctb-20210803T135111Z-pC4F/functional/cylc-poll/11-event-time
ok 1 - 11-event-time-validate
ok 2 - 11-event-time
ok 3 - 11-event-time-time-run-exit
ok    11645 ms ( 0.00 usr  0.00 sys +  2.98 cusr  0.58 csys =  3.56 CPU)
[13:53:11] tests/functional/broadcast/00-simple.t ................ 
/usr/bin/lsof
1..5
INSTALLED cylctb-20210803T135111Z-pC4F/functional/broadcast/00-simple from /tmp/tmp.I9XsLStCAk/cylctb-20210803T135111Z-pC4F/functional/broadcast/00-simple
ok 1 - 00-simple-validate
ok 2 - 00-simple-run
ok 3 - broadcast.ref-cmp-ok
ok 4 - select-broadcast-events.out-cmp-ok
ok 5 - select-broadcast-states.out-cmp-ok
ok    48690 ms ( 0.00 usr  0.01 sys + 11.25 cusr  2.20 csys = 13.46 CPU)
[13:53:11]

Test Summary Report
-------------------
tests/functional/shutdown/09-now2.t                 (Wstat: 0 Tests: 9 Failed: 3)
  Failed tests:  2-3, 7
Files=13, Tests=51, 120 wallclock secs ( 0.05 usr  0.03 sys + 38.79 cusr  7.26 csys = 46.13 CPU)
Result: FAIL
Error: Process completed with exit code 1.

With artifacts here: https://github.com/cylc/cylc-flow/pull/4331/checks?check_run_id=3231448457

[datamel]

I get traceback stopping workflows:

2021-08-13T11:34:37Z ERROR - 'str' object has no attribute 'describe'
	Traceback (most recent call last):
	  File "/cylc-flow/cylc/flow/scheduler.py", line 575, in start_scheduler
	    await self.main_loop()
	  File "/cylc-flow/cylc/flow/scheduler.py", line 1474, in main_loop
	    has_updated = await self.update_data_structure()
	  File "/cylc-flow/cylc/flow/scheduler.py", line 1531, in update_data_structure
	    self.data_store_mgr.update_data_structure()
	  File "/cylc-flow/cylc/flow/data_store_mgr.py", line 1076, in update_data_structure
	    self.update_workflow()
	  File "/cylc-flow/cylc/flow/data_store_mgr.py", line 1384, in update_workflow
	    str, get_workflow_status(self.schd))
	  File "/cylc-flow/cylc/flow/workflow_status.py", line 145, in get_workflow_status
	    status_msg = f'Stopping: {schd.stop_mode.describe()}'
	AttributeError: 'str' object has no attribute 'describe'
2021-08-13T11:34:37Z CRITICAL - Workflow shutting down - 'str' object has no attribute 'describe'

[oliver-sanders]

Got it.

[oliver-sanders]

Note: Ideally postpone merging this until the UIS branch is about to go in to reduce the window of breakage between Flow & UIS on master.

[datamel]

Checked out in conjunction with the sibling prs in ui and ui-server.
Thanks @oliver-sanders, all working smoothly now.