Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Cylc Hub button for jupyter-cylc #737

Closed
datamel opened this issue Aug 24, 2021 · 2 comments · Fixed by cylc/cylc-uiserver#331 or #969
Closed

Disable Cylc Hub button for jupyter-cylc #737

datamel opened this issue Aug 24, 2021 · 2 comments · Fixed by cylc/cylc-uiserver#331 or #969
Assignees
@datamel
Labels
bug Something isn't working good first issue Good for newcomers small
Milestone
1.2.0

Comments

@datamel
Copy link
Contributor

datamel commented Aug 24, 2021

After the trio: cylc/cylc-uiserver#230, #711 and cylc/cylc-flow#4331 have been merged, upon running jupyter-cylc and clicking the cylc hub button, you will get a 404 error. This button should be disabled instead.
@datamel datamel added this to the 1.0 milestone Aug 24, 2021
@datamel datamel added the bug Something isn't working label Aug 24, 2021
@kinow
Copy link
Member

kinow commented Aug 24, 2021

Good catch @datamel. Do we want to disable that button always, or only when running jupyter-cylc? If the latter, I think we will need some indication from the server as to whether to show or not the button (or show it greyed out?).

@datamel
Copy link
Contributor Author

datamel commented Aug 25, 2021

The latter, I think, makes most sense.

@kinow kinow modified the milestones: 1.0, 2.0 Sep 10, 2021
@kinow kinow added the good first issue Good for newcomers label Oct 6, 2021
@hjoliver hjoliver added the small label Oct 21, 2021
@oliver-sanders oliver-sanders modified the milestones: 2.0, 1.x Dec 7, 2021
@MetRonnie MetRonnie modified the milestones: 1.x, 1.0.1 Feb 15, 2022
@datamel datamel self-assigned this Mar 17, 2022
@oliver-sanders oliver-sanders modified the milestones: 1.1.0, 1.2.0 Mar 21, 2022
This was referenced Mar 22, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@datamel datamel

Labels
bug Something isn't working good first issue Good for newcomers small
Projects
None yet
Milestone
1.2.0
5 participants
@kinow @hjoliver @oliver-sanders @datamel @MetRonnie