Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sequential clock spawning fix #6206

Merged
merged 4 commits into from
Jul 9, 2024
Merged

sequential clock spawning fix #6206

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
10ba9a7
sequential clock spawning fix
dwsutherland Jul 8, 2024
3c846c0
change log entry
dwsutherland Jul 8, 2024
b25735e
Tidy
MetRonnie Jul 8, 2024
00784ee
Add test for sequential clock trigger bugfix
MetRonnie Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changes.d/6206.fix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixes the spawning of multiple parentless tasks off the same sequential wall-clock xtrigger.
2 changes: 2 additions & 0 deletions cylc/flow/xtrigger_mgr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -644,6 +644,8 @@ def call_xtriggers_async(self, itask: 'TaskProxy'):
if sig in self.sat_xtrig:
# Already satisfied, just update the task
itask.state.xtriggers[label] = True
if self.all_task_seq_xtriggers_satisfied(itask):
self.sequential_spawn_next.add(itask.identity)
elif _wall_clock(*ctx.func_args, **ctx.func_kwargs):
# Newly satisfied
itask.state.xtriggers[label] = True
Expand Down
Loading